[webkit-reviews] review granted: [Bug 96110] [chromium] gradient-with-scaled-ancestor.html rebaseline : [Attachment 162774] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 10 11:46:26 PDT 2012


Adrienne Walker <enne at google.com> has granted alexst at chromium.org's request for
review:
Bug 96110: [chromium] gradient-with-scaled-ancestor.html rebaseline
https://bugs.webkit.org/show_bug.cgi?id=96110

Attachment 162774: Patch
https://bugs.webkit.org/attachment.cgi?id=162774&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
(In reply to comment #3)
> (In reply to comment #2)
> > Why are there cross-platform results here? Is it just the scrollbars? If
so, can you just add a body { overflow: hidden } property on the test so you
just need one result?
> 
> Looking at garden-o-matic, Windows version has a difference from mac in the
gradient itself, but Linux and Mac only differ by scroll bars.
> 
> Hidden overflow sounds like a reasonable change, but it's not my test, so
we'll probably need to run it by the author since it'll break the mac baseline
as well. I can do it if you think it's worth pursuing.

Yuck.  I'm confused why Windows has a difference in the gradient, since they
should both be using Skia.

At any rate, I'll R+ this patch so it can land.  No need to hold up getting a
test rebaselined.


More information about the webkit-reviews mailing list