[webkit-reviews] review denied: [Bug 96049] Chromium: Scrollbar with tickmarks doesn't respond to clicks : [Attachment 162970] Patch

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has denied Sailesh Agrawal <sail at chromium.org>'s
request for review:
Bug 96049: Chromium: Scrollbar with tickmarks doesn't respond to clicks
https://bugs.webkit.org/show_bug.cgi?id=96049

Attachment 162970: Patch
https://bugs.webkit.org/attachment.cgi?id=162970&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162970&action=review


> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:216
> +    NSNumber* number = objc_getAssociatedObject(painter, &gLockedAlphaKey);

This definitely does not seem like the right approach. If you want to call
NSScrollerImp API, you should not use
objc_getAssociatedObject/objc_setAssociatedObject. You should call it the same
way we call all of the other NSScrollerImp APIs, by declaring it in
NSScrollerImpDetails.h

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:225
> +    objc_setAssociatedObject(painter, &gLockedAlphaKey, [NSNumber
numberWithBool:isLocked], OBJC_ASSOCIATION_RETAIN);

Same as above.