[webkit-reviews] review granted: [Bug 96279] Web Inspector: visualize layout root in Timeline : [Attachment 163147] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 10 10:06:58 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 96279: Web Inspector: visualize layout root in Timeline
https://bugs.webkit.org/show_bug.cgi?id=96279

Attachment 163147: Patch
https://bugs.webkit.org/attachment.cgi?id=163147&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163147&action=review


> Source/WebCore/inspector/TimelineRecordFactory.cpp:211
> +    data->setNumber("x", rect.x());

I've seen methods creating reactsint that class.

> Source/WebCore/inspector/front-end/TimelinePanel.js:950
> +	   const recordTypesToHighlight = [

Use object for faster lookup?


More information about the webkit-reviews mailing list