[webkit-reviews] review granted: [Bug 82560] Implement canvas v5 line dash feature : [Attachment 163120] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Justin Novosad <junov at google.com>'s
request for review:
Bug 82560: Implement canvas v5 line dash feature
https://bugs.webkit.org/show_bug.cgi?id=82560

Attachment 163120: Patch
https://bugs.webkit.org/attachment.cgi?id=163120&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163120&action=review


r=me, assuming you fix that one toDouble that should be toFloat

> Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:114
> -	   float elem = valueArray->getIndex(i).toFloat(exec);
> +	   float elem = valueArray->getIndex(i).toNumber(exec);

This change no longer makes sense. Should be left alone.