[webkit-reviews] review granted: [Bug 96255] Move InputTypeNames to a separate file : [Attachment 163082] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 96255: Move InputTypeNames to a separate file
https://bugs.webkit.org/show_bug.cgi?id=96255

Attachment 163082: Patch
https://bugs.webkit.org/attachment.cgi?id=163082&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163082&action=review


> Source/WebCore/WebCore.xcodeproj/project.pbxproj:25527
> +				C348612415FDE21E007A1CC9 /* InputTypeNames.h in
Headers */,

nit: please insert this entry in alphabetical order.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:28621
> +				C348612315FDE21E007A1CC9 /* InputTypeNames.cpp
in Sources */,

ditto.

> Source/WebCore/html/InputTypeNames.cpp:9
> + * Copyright (C) 1999 Lars Knoll (knoll at kde.org)
> + *		(C) 1999 Antti Koivisto (koivisto at kde.org)
> + *		(C) 2001 Dirk Mueller (mueller at kde.org)
> + * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc.
All rights reserved.
> + *		(C) 2006 Alexey Proskuryakov (ap at nypop.com)
> + * Copyright (C) 2007 Samuel Weinig (sam at webkit.org)
> + * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
> + * Copyright (C) 2012 Samsung Electronics. All rights reserved.

The original code was written by me in 2010, an Apple engineer updated some
lines in this year, and you add some lines.

* Copyright (C) 2012 Apple Inc. All rights reserved.
* Copyright (C) 2010, 2012 Google Inc. All rights reserved.

is enough.

> Source/WebCore/html/InputTypeNames.h:9
> + * Copyright (C) 1999 Lars Knoll (knoll at kde.org)
> + *		(C) 1999 Antti Koivisto (koivisto at kde.org)
> + *		(C) 2001 Dirk Mueller (mueller at kde.org)
> + * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc.
All rights reserved.
> + *		(C) 2006 Alexey Proskuryakov (ap at nypop.com)
> + * Copyright (C) 2007 Samuel Weinig (sam at webkit.org)
> + * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
> + * Copyright (C) 2012 Samsung Electronics. All rights reserved.

The original code of InputType.h was written by me in 2010, and you add some. 
So,

Copyright (C) 2010, 2012 Google Inc. All rights reserved.

is enough.