[webkit-reviews] review granted: [Bug 92362] [EFL][WK2] Add fullscreen enter / exit signals to the ewk_view API : [Attachment 163087] Patch 6

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 10 06:04:25 PDT 2012


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Alexander Shalamov
<alexander.shalamov at gmail.com>'s request for review:
Bug 92362: [EFL][WK2] Add fullscreen enter / exit signals to the ewk_view API
https://bugs.webkit.org/show_bug.cgi?id=92362

Attachment 163087: Patch 6
https://bugs.webkit.org/attachment.cgi?id=163087&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163087&action=review


Looks make sense now.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:36
> +bool full_screen_callback_called;

Please use webkit style for flag naming.


More information about the webkit-reviews mailing list