[webkit-reviews] review granted: [Bug 96119] Web Inspector: only display heap size statistics for timeline records when it makes sense : [Attachment 162803] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 96119: Web Inspector: only display heap size statistics for timeline
records when it makes sense
https://bugs.webkit.org/show_bug.cgi?id=96119

Attachment 162803: Patch
https://bugs.webkit.org/attachment.cgi?id=162803&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162803&action=review


> Source/WebCore/English.lproj/localizedStrings.js:741
> +localizedStrings["%s (delta %s)"] = "%s (delta %s)";

I'd rather show (+xx) or (-xx) without 'delta'.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:808
> +	   if ((this.usedHeapSize && this.category ===
WebInspector.TimelinePresentationModel.categories().scripting) ||
this.usedHeapSizeDelta) {

Should be: this.usedHeapSize && (this.category ===
WebInspector.TimelinePresentationModel.categories().scripting ||
this.usedHeapSizeDelta)