[webkit-reviews] review granted: [Bug 96259] [EFL] Create a toggle button for closed captions : [Attachment 163093] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 96259: [EFL] Create a toggle button for closed captions
https://bugs.webkit.org/show_bug.cgi?id=96259

Attachment 163093: Patch
https://bugs.webkit.org/attachment.cgi?id=163093&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163093&action=review


> Source/WebCore/platform/efl/RenderThemeEfl.cpp:1303
> +    Node* mediaNode = object->node() ? object->node()->shadowHost() : 0;
> +    if (!mediaNode)
> +	   mediaNode = object->node();
> +    if (!mediaNode || (!mediaNode->hasTagName(videoTag)))
> +	   return false;

So this is how it is done for other ports?