[webkit-reviews] review granted: [Bug 96252] Web Inspector: [Elements] Poor performance upon continuous attribute changes : [Attachment 163074] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 10 02:51:14 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 96252: Web Inspector: [Elements] Poor performance upon continuous attribute
changes
https://bugs.webkit.org/show_bug.cgi?id=96252

Attachment 163074: Patch
https://bugs.webkit.org/attachment.cgi?id=163074&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163074&action=review


> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:2091
> +	   for (var id in this._recentlyModifiedNodes) {

var nodesToUpdate = Object.values(this._recentlyModifiedNodes);
... = nodesToUpdate.length > 10;

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:2117
> +	       if (entry.updated) {

entry[WebInspector.ElementsTreeUpdater.ChangeType.Updated]


More information about the webkit-reviews mailing list