[webkit-reviews] review granted: [Bug 96246] [WK2] Make WK2 C API headers compile in the Qt build on Windows : [Attachment 163067] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 10 01:49:25 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 96246: [WK2] Make WK2 C API headers compile in the Qt build on Windows
https://bugs.webkit.org/show_bug.cgi?id=96246

Attachment 163067: Patch
https://bugs.webkit.org/attachment.cgi?id=163067&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163067&action=review


> Source/WebKit2/Shared/API/c/WKBase.h:32
> +#if (defined(WIN32) || defined(_WIN32)) && !defined(BUILDING_QT__)

This couldn't be PLATFORM(WIN) && instead?


More information about the webkit-reviews mailing list