[webkit-reviews] review granted: [Bug 96231] Refactored op_tear_off* to support activations that don't allocate space for 'arguments' : [Attachment 163044] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 96231: Refactored op_tear_off* to support activations that don't allocate
space for 'arguments'
https://bugs.webkit.org/show_bug.cgi?id=96231

Attachment 163044: Patch
https://bugs.webkit.org/attachment.cgi?id=163044&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163044&action=review


> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1116
> +    // We can't hash JSValue(), so just return a non-uniqued value.

We could cache this separately from the hashtable (remember the first added in
a separate var).