[webkit-reviews] review granted: [Bug 96228] Simplify WebKit2 XPC service backend now that I know it doesn't need to soft link WebKit2.framework : [Attachment 163043] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 9 23:13:06 PDT 2012


mitz at webkit.org has granted Sam Weinig <sam at webkit.org>'s request for review:
Bug 96228: Simplify WebKit2 XPC service backend now that I know it doesn't need
to soft link WebKit2.framework
https://bugs.webkit.org/show_bug.cgi?id=96228

Attachment 163043: Patch
https://bugs.webkit.org/attachment.cgi?id=163043&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=163043&action=review


> Source/WebKit2/WebProcess/mac/WebProcessXPCServiceMain.mm:52
> +	       assert(type == XPC_TYPE_DICTIONARY);

Now that this is in the framework, I think you can use ASSERT.


More information about the webkit-reviews mailing list