[webkit-reviews] review granted: [Bug 96127] JSC: Fix some llint C++ interpreter bugs : [Attachment 163028] New patch with extra stuff. See accompanying comment for details.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 9 20:56:44 PDT 2012


Geoffrey Garen <ggaren at apple.com> has granted  review:
Bug 96127: JSC: Fix some llint C++ interpreter bugs
https://bugs.webkit.org/show_bug.cgi?id=96127

Attachment 163028: New patch with extra stuff.	See accompanying comment for
details.
https://bugs.webkit.org/attachment.cgi?id=163028&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163028&action=review


EWS builders are happy, and this patch resolves the complaint I heard about
ASSERT(), so I'm marking it r+.

> Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:224
> +#if COMPILER(MSVC)

FWIW, other compilers may issue the same complaint eventually.


More information about the webkit-reviews mailing list