[webkit-reviews] review denied: [Bug 96168] WebKit exposes incorrect bounds for embedded SVG in HTML : [Attachment 162946] patch

Sat Sep 8 22:09:34 PDT 2012

Dirk Schulze <krit at webkit.org> has denied chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 96168: WebKit exposes incorrect bounds for embedded SVG in HTML
https://bugs.webkit.org/show_bug.cgi?id=96168

Attachment 162946: patch 
https://bugs.webkit.org/attachment.cgi?id=162946&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
Not all elements inherit from RenderSVGModelObject, so I doubt that this extra
check will help you a lot (SVGImage or SVG*Text* as example). Something that we
usually do is checking the elements type (node()->isSVGElement()). You need to
be carful with inline SVG elements so:

<body>
<svg>
...
</svg>
</body>

These elements are treated like HTML elements, but still return true for
isSVGElement().

Can you add examples with <text> and <image> as well please?