[webkit-reviews] review denied: [Bug 92504] [EFL][Qt][WK2] Implement shared undo controller for EFL and Qt port : [Attachment 162758] new approach with shared undo controller

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Michal Pakula vel Rutka
<m.pakula at samsung.com>'s request for review:
Bug 92504: [EFL][Qt][WK2] Implement shared undo controller for EFL and Qt port
https://bugs.webkit.org/show_bug.cgi?id=92504

Attachment 162758: new approach with shared undo controller
https://bugs.webkit.org/attachment.cgi?id=162758&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162758&action=review


>> Source/WebKit2/Target.pri:787
>> +	    UIProcess/qt/QtViewportHandler.h \
> 
> This hunk does not seem right to me. There is no QtViewportHandler.h any
more, probably slipped in when you rebased your patch.

Looks overall good, but it's going to need a rebase to adjust to the changes on
the Qt side, as Andras pointed out :)