[webkit-reviews] review requested: [Bug 89993] [CSS Exclusions] Enable css exclusions for multiple blocks per element : [Attachment 162919] Incorporating feedback

[bugzilla-daemon at webkit.org]

Bear Travis <betravis at adobe.com> has asked  for review:
Bug 89993: [CSS Exclusions] Enable css exclusions for multiple blocks per
element
https://bugs.webkit.org/show_bug.cgi?id=89993

Attachment 162919: Incorporating feedback
https://bugs.webkit.org/attachment.cgi?id=162919&action=review

------- Additional Comments from Bear Travis <betravis at adobe.com>
Fixing up patch
WrapShapeInfo only deals with shape-inside, which is why one RenderBlock's
shape-inside affects all descendants, and a new shape-inside overrides the
previous one.
I have added bug 96160 to rename WrapShapeInfo to something more useful,
ExclusionShapeInfo or ShapeInsideInfo.
I have also logged bug 96161 to refactor WrapShapeInfo to be more
straightforward when dealing with logical vs physical coordinates. WrapShapes
should be sized physically (based on the width/height of their block), but
passed logical coordinates when computing line segments. Other fixes:
LayoutState::wrapShapeInfo was made const
Factored out block->view()->layoutState()->wrapShapeInfo() to a
layoutWrapShapeInfo() function. RenderBlock::wrapShapeInfo() is still necessary
to tell whether or not a given block has a shape-inside from CSS
Renamed logicalTopOffset to absoluteLogicalTop
absoluteLogicalTop will now use layoutOffset width or height depending on
writing mode
shapeTop will be renamed to logicalTop as part of bug 96161