[webkit-reviews] review granted: [Bug 95915] Extend third-party storage blocking API to optionally allow blocking all storage : [Attachment 162843] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Jeffrey Pfau
<jeffrey at endrift.com>'s request for review:
Bug 95915: Extend third-party storage blocking API to optionally allow blocking
all storage
https://bugs.webkit.org/show_bug.cgi?id=95915

Attachment 162843: Patch
https://bugs.webkit.org/attachment.cgi?id=162843&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162843&action=review


I'd like you to consider making the changes I suggested, but won't hold up the
patch any longer.

> Source/WebCore/page/SecurityOrigin.h:52
> +    enum StorageBlockingPolicy {
> +	   AllowAllStorage = 0,
> +	   BlockAllStorage,
> +	   BlockThirdPartyStorage
> +    };

It reads better to me if these enums move from most permissive to least
permissive.

-Allow All
-Block 3rd Parties
-Block All.

> Source/WebKit2/UIProcess/API/C/WKPreferences.h:43
> +enum WKStorageBlockingPolicy {
> +    kWKAllowAllStorage = 0,
> +    kWKBlockAllStorage,
> +    kWKBlockThirdPartyStorage
> +};

Same comment.