[webkit-reviews] review requested: [Bug 96125] StringImpl::find(StringImpl*) doesn't handle cases where search and match strings are different bitness : [Attachment 162869] Patch with changes for both exported find()'s and reverseFind()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 7 14:20:12 PDT 2012
Michael Saboff <msaboff at apple.com> has asked for review:
Bug 96125: StringImpl::find(StringImpl*) doesn't handle cases where search and
match strings are different bitness
https://bugs.webkit.org/show_bug.cgi?id=96125
Attachment 162869: Patch with changes for both exported find()'s and
reverseFind()
https://bugs.webkit.org/attachment.cgi?id=162869&action=review
------- Additional Comments from Michael Saboff <msaboff at apple.com>
(In reply to comment #4)
> (From update of attachment 162818 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=162818&action=review
>
> r- for the the other find().
>
> Why not update find(StringImpl* matchString, unsigned index) similarly?
Okay - done. I also added reverseFind().
More information about the webkit-reviews
mailing list