[webkit-reviews] review granted: [Bug 96124] AX: Chromium needs access to canvasHasFallbackContent : [Attachment 162811] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 7 13:57:20 PDT 2012


chris fleizach <cfleizach at apple.com> has granted Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 96124: AX: Chromium needs access to canvasHasFallbackContent
https://bugs.webkit.org/show_bug.cgi?id=96124

Attachment 162811: Patch
https://bugs.webkit.org/attachment.cgi?id=162811&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162811&action=review


>
Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:243

> +	   roleString += "WithFallbackContent";

it's a little weird to modify the role string like this
i might have chosen to make it "AXCanvas (With Fallback Content)" 
but that's a minor nit


More information about the webkit-reviews mailing list