[webkit-reviews] review granted: [Bug 96136] Regression: check-webkit-style no longer checks TestExpectations for syntax errors : [Attachment 162838] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 96136: Regression: check-webkit-style no longer checks TestExpectations for
syntax errors
https://bugs.webkit.org/show_bug.cgi?id=96136

Attachment 162838: Patch
https://bugs.webkit.org/attachment.cgi?id=162838&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162838&action=review


> Tools/Scripts/webkitpy/style/checkers/test_expectations.py:-80
> -	   # FIXME: we should pass in the filenames here if possible, and
ensure
> -	   # that this works with with cascading expectations files and remove
the overrides param.

As discussed in person, I think with cascading expectations we want to lint
each file in isolation and so doing nothing special is correct. I'll r+ for now
to get the linter running again. Dirk can clarify if I'm wrong when he returns
from vacation.