[webkit-reviews] review granted: [Bug 96129] Make RenderBox::computeLogicalWidthInRegion const : [Attachment 162799] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 96129: Make RenderBox::computeLogicalWidthInRegion const
https://bugs.webkit.org/show_bug.cgi?id=96129

Attachment 162799: Patch
https://bugs.webkit.org/attachment.cgi?id=162799&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162799&action=review


>> Source/WebCore/rendering/RenderBox.cpp:1715
>> +		computedValues.m_margins.m_end = containerLogicalWidth -
computedValues.m_extent - cb->marginStartForChild(this);
> 
> I could make a helper function for this on MarginValues if you think it
helps.

Can you just create a local variable before the if/else?
LayoutUnit newMargin = containerLogicalWidth - computedValues.m_extent -
cb->marginStartForChild(this);