[webkit-reviews] review granted: [Bug 96068] webkit.py gdb pretty printer can't print CString : [Attachment 162671] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 7 09:53:30 PDT 2012


Tony Chang <tony at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 96068: webkit.py gdb pretty printer can't print CString
https://bugs.webkit.org/show_bug.cgi?id=96068

Attachment 162671: Patch
https://bugs.webkit.org/attachment.cgi?id=162671&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162671&action=review


> Tools/gdb/webkit.py:119
> +	   data =
self.val['m_buffer']['m_ptr']['m_data'].cast(gdb.lookup_type("char").pointer())


Nit: I would use ' instead of " to be consistent with the code around it.


More information about the webkit-reviews mailing list