[webkit-reviews] review granted: [Bug 96101] Web Inspector: NMI: move WebCore specific code to separate header : [Attachment 162767] for mac bot

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 7 08:24:29 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 96101: Web Inspector: NMI: move WebCore specific code to separate header
https://bugs.webkit.org/show_bug.cgi?id=96101

Attachment 162767: for mac bot
https://bugs.webkit.org/attachment.cgi?id=162767&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162767&action=review


> Source/WebCore/WebCore.vcproj/WebCore.vcproj:55306
> +			       
RelativePath="..\dom\WebCoreMemoryInstrumentation.cpp"

I believe WebCore/inspector would be a better place for these files.

> Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp:34
>  #include "MemoryInstrumentationImpl.h"

No need in this include anymore.


More information about the webkit-reviews mailing list