[webkit-reviews] review granted: [Bug 96088] Web Inspector: support empty entries in source maps. : [Attachment 162716] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 96088: Web Inspector: support empty entries in source maps.
https://bugs.webkit.org/show_bug.cgi?id=96088

Attachment 162716: Patch
https://bugs.webkit.org/attachment.cgi?id=162716&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162716&action=review


> Source/WebCore/inspector/front-end/CompilerScriptMapping.js:44
> +    this._originalUISourceCodeForScriptId = {};

Can we reuse this._uiSourceCodeByURL ?

> Source/WebCore/inspector/front-end/CompilerScriptMapping.js:87
>	   var result = [];

uiSourceCodes() method is now used for tests only so I would get rid of it
altogether.

> LayoutTests/http/tests/inspector/compiler-script-mapping.html:142
>	       InspectorTest.checkUILocation(uiSourceCodeList[0], 4, 4,
mapping.rawLocationToUILocation(WebInspector.debuggerModel.createRawLocation(sc
ript, 0, 81)));

Shouldn't we do some checkUILocation/checkRawLocation for empty entries case?