[webkit-reviews] review denied: [Bug 95720] Simplify hitTestResultAtPoint and nodesFromRect APIs : [Attachment 162262] Patch

[bugzilla-daemon at webkit.org]

Allan Sandfeld Jensen <allan.jensen at nokia.com> has denied Allan Sandfeld Jensen
<allan.jensen at nokia.com>'s request for review:
Bug 95720: Simplify hitTestResultAtPoint and nodesFromRect APIs
https://bugs.webkit.org/show_bug.cgi?id=95720

Attachment 162262: Patch
https://bugs.webkit.org/attachment.cgi?id=162262&action=review

------- Additional Comments from Allan Sandfeld Jensen <allan.jensen at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162262&action=review


I seem to have managed to mix up the parameters in a few places which is why
the tests fail now.

> Source/WebCore/page/EventHandler.cpp:1010
> -    HitTestResult hitTest = hitTestResultAtPoint(m_panScrollStartPos, true);

> +    HitTestResult hitTest = hitTestResultAtPoint(m_panScrollStartPos,
HitTestRequest::Default | HitTestRequest::AllowChildFrameContent);

Wrong autocomplete, should AllowShadowContent.

> Source/WebCore/page/EventHandler.cpp:2483
> -    HitTestResult result = hitTestResultAtPoint(hitTestPoint,
/*allowShadowContent*/ true, /*ignoreClipping*/ false, DontHitTestScrollbars,
hitType, touchRadius);
> +    HitTestResult result = hitTestResultAtPoint(hitTestPoint,
HitTestRequest::Default | HitTestRequest::AllowChildFrameContent, touchRadius);


Ditto

> Source/WebCore/page/EventHandler.cpp:2501
> -    HitTestResult result = hitTestResultAtPoint(hitTestPoint,
/*allowShadowContent*/ true, /*ignoreClipping*/ false, DontHitTestScrollbars,
hitType, touchRadius);
> +    HitTestResult result = hitTestResultAtPoint(hitTestPoint,
HitTestRequest::Default | HitTestRequest::AllowChildFrameContent, touchRadius);


Ditto

> Source/WebCore/page/Frame.cpp:727
> -    HitTestResult result = eventHandler()->hitTestResultAtPoint(framePoint,
true);
> +    HitTestResult result = eventHandler()->hitTestResultAtPoint(framePoint,
HitTestRequest::Default | HitTestRequest::AllowChildFrameContent);

Ditto