[webkit-reviews] review denied: [Bug 94433] Add call stacks to Content Security Policy checks when relevant. : [Attachment 161022] Chromium vs Everything Else.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 7 01:46:18 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has denied  review:
Bug 94433: Add call stacks to Content Security Policy checks when relevant.
https://bugs.webkit.org/show_bug.cgi?id=94433

Attachment 161022: Chromium vs Everything Else.
https://bugs.webkit.org/attachment.cgi?id=161022&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161022&action=review


>
LayoutTests/http/tests/inspector-enabled/contentSecurityPolicy-blocks-setInterv
al-expected.txt:7
> + [native code]:1

As Vsevolod pointed out this is a regression as now we don't have exact
location for JSC. I guess that JSMainThreadExecState::currentState returns 0 in
this case because it doesn't use JSMainThreadExecState::call. This can be fixed
by adding 
JSMainThreadExecState currentState(exec);
to ScheduledAction::create.

r- for this


More information about the webkit-reviews mailing list