[webkit-reviews] review granted: [Bug 95745] [GTK] Move user agent helpers to WebCore : [Attachment 162584] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 95745: [GTK] Move user agent helpers to WebCore
https://bugs.webkit.org/show_bug.cgi?id=95745

Attachment 162584: Patch
https://bugs.webkit.org/attachment.cgi?id=162584&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162584&action=review


Looks good to me, just consider adding a default application name when not
provided.

> Source/WebCore/platform/gtk/UserAgentGtk.cpp:102
> +    return String::format("%s %s/%s", staticUA.utf8().data(),
applicationName.utf8().data(), finalApplicationVersion.utf8().data());

So, if application name is empty, we end up with something like "/1.2.3", it's
a bit weird. If we don't want to use the program name as default we could use
something like "WebKitGTK+ based browser/1.2.3"

> Source/WebCore/platform/gtk/UserAgentGtk.h.in:38
> +const char* platformForUAString();
> +String platformVersionForUAString();

Do we need these to be public?