[webkit-reviews] review denied: [Bug 95556] [Qt] QNX OpenGL enabled build fails in OpenGLShims.cpp : [Attachment 161664] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Milian Wolff
<milian.wolff at kdab.com>'s request for review:
Bug 95556: [Qt] QNX OpenGL enabled build fails in OpenGLShims.cpp
https://bugs.webkit.org/show_bug.cgi?id=95556

Attachment 161664: Patch
https://bugs.webkit.org/attachment.cgi?id=161664&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I think you're right in the sense that functions like glBlitFramebufferANGLE
and other extensions should only be looked up at run-time. That means we should
_not_ try to access ::glBlitFramebufferANGLE directly and we should _not_
#undef GL_ANGLE_framebuffer_blit but instead use ASSIGN_FUNCTION_TABLE_ENTRY()
to look it up. If there is a fallback for example, then we should fall back.