[webkit-reviews] review denied: [Bug 96047] JSC should have a zombie mode : [Attachment 162638] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 6 18:29:37 PDT 2012


Geoffrey Garen <ggaren at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 96047: JSC should have a zombie mode
https://bugs.webkit.org/show_bug.cgi?id=96047

Attachment 162638: Patch
https://bugs.webkit.org/attachment.cgi?id=162638&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162638&action=review


> Source/JavaScriptCore/heap/Heap.cpp:741
> +    if (Options::useZombieMode() || sweepToggle == DoSweep) {

Looking at this again, I don't think you can piggy-back on this for zombies. If
the call to shrink unmaps some blocks, they may remap into the heap later,
failing to be immortal zombies.

I think you should just add a call to sweep() inside zombifyDeadObjects().


More information about the webkit-reviews mailing list