[webkit-reviews] review denied: [Bug 96047] JSC should have a zombie mode : [Attachment 162633] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 6 18:14:10 PDT 2012


Geoffrey Garen <ggaren at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 96047: JSC should have a zombie mode
https://bugs.webkit.org/show_bug.cgi?id=96047

Attachment 162633: Patch
https://bugs.webkit.org/attachment.cgi?id=162633&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162633&action=review


Looks good, but you have a bug.

> Source/JavaScriptCore/heap/Heap.cpp:850
> +class ZombifyCellFunctor : public MarkedBlock::VoidFunctor {

Add a data member that causes us optionally set the mark bit as we zombify, if
in immortal mode.

> Source/JavaScriptCore/heap/MarkedBlock.h:313
> +    inline void MarkedBlock::zombieClearMarks()

Remove this.


More information about the webkit-reviews mailing list