[webkit-reviews] review denied: [Bug 95915] Extend third-party storage blocking API to optionally allow blocking all storage : [Attachment 162604] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied  review:
Bug 95915: Extend third-party storage blocking API to optionally allow blocking
all storage
https://bugs.webkit.org/show_bug.cgi?id=95915

Attachment 162604: Patch
https://bugs.webkit.org/attachment.cgi?id=162604&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162604&action=review


> Source/WebKit2/UIProcess/API/C/WKPreferences.h:210
> -WK_EXPORT void
WKPreferencesSetThirdPartyStorageBlockingEnabled(WKPreferencesRef
preferencesRef, bool enabled);
> -WK_EXPORT bool
WKPreferencesGetThirdPartyStorageBlockingEnabled(WKPreferencesRef
preferencesRef);
> +WK_EXPORT void WKPreferencesSetStorageBlockingPolicy(WKPreferencesRef
preferencesRef, uint32_t policy);
> +WK_EXPORT uint32_t WKPreferencesGetStorageBlockingPolicy(WKPreferencesRef
preferencesRef);

This should be exposed as an enum, not a uint32_t

There's precedent for this - See WKPreferencesPrivate.h for a directly
comparable example.