[webkit-reviews] review denied: [Bug 95661] [Chromium] Multiple commits without invalidation allowed per redraw. : [Attachment 162622] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied David Reveman
<reveman at chromium.org>'s request for review:
Bug 95661: [Chromium] Multiple commits without invalidation allowed per redraw.
https://bugs.webkit.org/show_bug.cgi?id=95661

Attachment 162622: Patch
https://bugs.webkit.org/attachment.cgi?id=162622&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162622&action=review


> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:2915
> +	   if (m_numDidCommit < 50) {

this is not a good unit test. a unit test should test for a specific case, not
just blindly loop a bunch.  run through the states you care about and then end
the test - you definitely don't care about 50 different states

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:2972
> +	   if (m_numAnimate < 50) {

same here. make the test specific