[webkit-reviews] review granted: [Bug 95942] [GTK] Multiple feature defines in webcore_cppflags can occur : [Attachment 162442] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 95942: [GTK] Multiple feature defines in webcore_cppflags can occur
https://bugs.webkit.org/show_bug.cgi?id=95942

Attachment 162442: Patch
https://bugs.webkit.org/attachment.cgi?id=162442&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162442&action=review


Looks good, though I have a small suggestion for a rename.

> Source/WebCore/GNUmakefile.am:773
> +feature_defines_unstable_features +=

How about unstable_feature_defines? It avoids using the word "features" twice
in this variable name.