[webkit-reviews] review requested: [Bug 95793] Improve the initialization of empty strings : [Attachment 162154] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 6 14:31:46 PDT 2012
Benjamin Poulain <benjamin at webkit.org> has asked for review:
Bug 95793: Improve the initialization of empty strings
https://bugs.webkit.org/show_bug.cgi?id=95793
Attachment 162154: Patch
https://bugs.webkit.org/attachment.cgi?id=162154&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
> I should make the solution explicit with rvalue reference, and that will also
solve the problem of operator=.
I tried that, it does not make any difference for the compiler. I am pleasantly
surprised how smart the compiler is with this.
Using r-value adds risks and complexity, so I prefer the current version.
Putting the original patch back for review.
More information about the webkit-reviews
mailing list