[webkit-reviews] review denied: [Bug 95997] [chromium] Add touchscreen specific fling curve parametrization : [Attachment 162545] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 95997: [chromium] Add touchscreen specific fling curve parametrization
https://bugs.webkit.org/show_bug.cgi?id=95997

Attachment 162545: Patch
https://bugs.webkit.org/attachment.cgi?id=162545&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162545&action=review


> Source/WebCore/platform/chromium/support/PlatformGestureCurveFactory.cpp:54
> +	   return
WebCore::TouchpadFlingPlatformGestureCurve::createForTouchScreen(point,
cumulativeScroll);

Touchpad...ForTouchScreen?  What does that mean?  It doesn't seem sensical to
create a Touchpad fling curve for a touch screen.

I think what you really want is another fling curve type, if you want to be
consistent with the existing curve type hierarchy.  Or refactor the curve stuff
to make more sense.