[webkit-reviews] review denied: [Bug 96001] [BlackBerry] Implement a color picker : [Attachment 162560] updated patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Crystal Zhang <haizhang at rim.com>'s
request for review:
Bug 96001: [BlackBerry]  Implement a color picker
https://bugs.webkit.org/show_bug.cgi?id=96001

Attachment 162560: updated patch
https://bugs.webkit.org/attachment.cgi?id=162560&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162560&action=review


The comment needs to be fixed, and Cristophe's concern too.

> Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp:88
> +    // Return -1 if user cancel the selection.

Comment is a bit wierd.

> Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp:91
> +    static const char* cancelValue = "-1";

I dont like using -1 in a string. Or keeping a static var for it. You also
still need to convert it to a String each time. Maybe an empty string can be
used to cancel? But this does not need to be fixed with this patch.