[webkit-reviews] review granted: [Bug 96003] Fix WTF.Lrint on 32-bit platforms : [Attachment 162559] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 96003: Fix WTF.Lrint on 32-bit platforms
https://bugs.webkit.org/show_bug.cgi?id=96003

Attachment 162559: Patch
https://bugs.webkit.org/attachment.cgi?id=162559&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162559&action=review


> Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp:49
> +	 // Largest double number with 0.5 precision and one halfway rounding
case below.
> +	 EXPECT_EQ(lrint(pow(2.0, 52) - 0.5), pow(2.0, 52));
> +	 EXPECT_EQ(lrint(pow(2.0, 52) - 1.5), pow(2.0, 52) - 2);
> +	 // Smallest double number with 0.5 precision and one halfway rounding
case above.
> +	 EXPECT_EQ(lrint(-pow(2.0, 52) + 0.5), -pow(2.0, 52));
> +	 EXPECT_EQ(lrint(-pow(2.0, 52) + 1.5), -pow(2.0, 52) + 2);

Wrong indent.