[webkit-reviews] review denied: [Bug 96001] [BlackBerry] Implement a color picker : [Attachment 162544] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 6 12:23:08 PDT 2012
Rob Buis <rwlbuis at gmail.com> has denied Crystal Zhang <haizhang at rim.com>'s
request for review:
Bug 96001: [BlackBerry] Implement a color picker
https://bugs.webkit.org/show_bug.cgi?id=96001
Attachment 162544: patch
https://bugs.webkit.org/attachment.cgi?id=162544&action=review
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162544&action=review
Looks good, but please address Antonio and my comments.
> Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.h:48
> + void closePopup();
It seems many of these can be private.
More information about the webkit-reviews
mailing list