[webkit-reviews] review granted: [Bug 95861] [Chromium] Define new setSharedWorkerRepository function in preparation for removing WebKitPlatformSupport::sharedWorkerRepository() : [Attachment 162507] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 95861: [Chromium] Define new setSharedWorkerRepository function in
preparation for removing WebKitPlatformSupport::sharedWorkerRepository()
https://bugs.webkit.org/show_bug.cgi?id=95861

Attachment 162507: Patch
https://bugs.webkit.org/attachment.cgi?id=162507&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162507&action=review


> Source/WebKit/chromium/public/WebKit.h:34
> +#include "WebSharedWorkerRepository.h"

You don't need this #include.  You can just forward declare
WebSharedWorkerRepository

> Source/WebKit/chromium/src/SharedWorkerRepository.cpp:65
> +void setSharedWorkerRepository(WebSharedWorkerRepository* repository)

Maybe we should put this function in WebSharedWorkerRepository.h rather than
WebKit.h?