[webkit-reviews] review denied: [Bug 94274] Move Shadow DOM inspection feature out from experiments if Shadow DOM flag is enabled : [Attachment 162446] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 6 10:19:49 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Hajime Morrita
<morrita at google.com>'s request for review:
Bug 94274: Move Shadow DOM inspection feature out from experiments if Shadow
DOM flag is enabled
https://bugs.webkit.org/show_bug.cgi?id=94274

Attachment 162446: Patch
https://bugs.webkit.org/attachment.cgi?id=162446&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
As per discussion: this check does not give us much. We should filter shadom
Dom out on front-end side when it is not enabled (we should convert experiment
into a setting that toggles it instead). And we need to address the r/o roots
(thanks to Dimitri for reminding).


More information about the webkit-reviews mailing list