[webkit-reviews] review requested: [Bug 95812] Add 8 bit string data path to TextRun : [Attachment 162515] Patch with fixes for failing platforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 6 08:47:12 PDT 2012


Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 95812: Add 8 bit string data path to TextRun
https://bugs.webkit.org/show_bug.cgi?id=95812

Attachment 162515: Patch with fixes for failing platforms
https://bugs.webkit.org/attachment.cgi?id=162515&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
Fixed the non-Mac platforms by changing the calls to characters() and data() to
characters16() and data16() and by disallowing the creation of 8 bit text runs
via compile switches.  These other platforms will have to make the appropriate
changes after the patch lands.


More information about the webkit-reviews mailing list