[webkit-reviews] review denied: [Bug 95957] Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol. : [Attachment 162487] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 6 06:16:24 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 95957: Web Inspector: NMI: switch to hierarchical identifiers of
MemoryBlockTypes and use these identifiers in protocol.
https://bugs.webkit.org/show_bug.cgi?id=95957

Attachment 162487: Patch
https://bugs.webkit.org/attachment.cgi?id=162487&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162487&action=review


> Source/WebCore/loader/cache/CachedResource.cpp:806
> +    MemoryClassInfo info(memoryObjectInfo, this,
GenericMemoryTypes::Undefined);

There may be instances of the CachedResource class(that are not descendants).


More information about the webkit-reviews mailing list