[webkit-reviews] review denied: [Bug 95957] Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol. : [Attachment 162459] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 95957: Web Inspector: NMI: switch to hierarchical identifiers of
MemoryBlockTypes and use these identifiers in protocol.
https://bugs.webkit.org/show_bug.cgi?id=95957

Attachment 162459: Patch
https://bugs.webkit.org/attachment.cgi?id=162459&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162459&action=review


> Source/WebCore/dom/MemoryInstrumentation.cpp:40
> +MemoryObjectType GenericMemoryTypes::OwnersTypePlaceholder =
"OwnersTypePlaceholder";

The new name is too verbose and still sounds unclear to me, I'd rather leave it
as Other or passed 0 where the Other is used since we should never report types
with such type anyways.

> Source/WebCore/dom/MemoryInstrumentation.cpp:42
> +MemoryObjectType WebCoreMemoryTypes::DOMTree = "DOMTree";

DOMTree -> Page ?

> Source/WebCore/dom/MemoryInstrumentation.cpp:50
> +MemoryObjectType WebCoreMemoryTypes::CachedResource =
"MemoryCache.RawResource";

CachedResource -> CachedResourceRaw