[webkit-reviews] review granted: [Bug 95938] Make CSSPrimitiveValue::cleanup() handle all UnitTypes, fixing memory leak in the process. : [Attachment 162430] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 6 04:48:26 PDT 2012


Andreas Kling <kling at webkit.org> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 95938: Make CSSPrimitiveValue::cleanup() handle all UnitTypes, fixing
memory leak in the process.
https://bugs.webkit.org/show_bug.cgi?id=95938

Attachment 162430: Patch
https://bugs.webkit.org/attachment.cgi?id=162430&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
Great, r=me.

Just make sure to fix the EWS warning first:
CSSPrimitiveValue.cpp:368:12: error: enumeration value 'CSS_DASHBOARD_REGION'
not handled in switch [-Werror=switch]


More information about the webkit-reviews mailing list