[webkit-reviews] review granted: [Bug 95965] [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2 : [Attachment 162465] Patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has granted Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 95965: [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
https://bugs.webkit.org/show_bug.cgi?id=95965

Attachment 162465: Patch
https://bugs.webkit.org/attachment.cgi?id=162465&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162465&action=review


awesome!

> Source/WebCore/Target.pri:3930
> +    WEBKIT += ANGLE

nitpick, but WEBKIT += angle

We take care of the casing in default_post

> Source/WebKit/WebKit1.pro:155
> +contains(DEFINES, WTF_USE_3D_GRAPHICS=1): WEBKIT += ANGLE

Ditto

> Source/api.pri:88
> +contains(DEFINES, WTF_USE_3D_GRAPHICS=1): WEBKIT += ANGLE

Ditto