[webkit-reviews] review granted: [Bug 95899] Three XSLTProcessor functions don't need to be [Custom] : [Attachment 162347] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 5 22:11:24 PDT 2012


Kentaro Hara <haraken at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 95899: Three XSLTProcessor functions don't need to be [Custom]
https://bugs.webkit.org/show_bug.cgi?id=95899

Attachment 162347: Patch
https://bugs.webkit.org/attachment.cgi?id=162347&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162347&action=review


>>> Source/WebCore/ChangeLog:13
>>> +	     error, we return null instead of undefined. This change is
unlikely to
>> 
>> How do other browsers behave in this case?
> 
> I suspect other browsers throw exception, which we do as well for newer
interfaces.  For older interfaces, we tend to use
[Optional=DefaultIsUndefined].

Thanks for the clarification. Then the change sounds reasonable.


More information about the webkit-reviews mailing list