[webkit-reviews] review granted: [Bug 95811] WebKit2 IPC always sends strings using 16 bit data format : [Attachment 162359] Patch with ChangeLog tab removed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 5 21:42:09 PDT 2012


Benjamin Poulain <benjamin at webkit.org> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 95811: WebKit2 IPC always sends strings using 16 bit data format
https://bugs.webkit.org/show_bug.cgi?id=95811

Attachment 162359: Patch with ChangeLog tab removed
https://bugs.webkit.org/attachment.cgi?id=162359&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162359&action=review


Woot! Very nice.

> Source/WebKit2/Platform/CoreIPC/ArgumentCoders.cpp:105
> +	   encoder->encodeFixedLengthData(reinterpret_cast<const
uint8_t*>(string.characters()), length * sizeof(UChar), __alignof(UChar));

This should be characters16().
String::characters() is the "weak" version.


More information about the webkit-reviews mailing list