[webkit-reviews] review denied: [Bug 95134] [chromium] Support high DPI scroll bar on top level web frame. : [Attachment 162285] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has denied Robert Flack
<flackr at chromium.org>'s request for review:
Bug 95134: [chromium] Support high DPI scroll bar on top level web frame.
https://bugs.webkit.org/show_bug.cgi?id=95134

Attachment 162285: Patch
https://bugs.webkit.org/attachment.cgi?id=162285&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162285&action=review


> Source/Platform/chromium/public/WebLayer.h:108
> +    // Set to apply a scale factor used when painting and drawing this
layer's content. Defaults to 1.0.
> +    virtual void setContentsScale(float) = 0;
> +    virtual float contentsScale() = 0;
> +

No no no.  I think twiz's change in bug 95094 makes this unnecessary.

> Source/WebCore/page/FrameView.cpp:708
> +void FrameView::deviceOrPageScaleFactorChanged()
> +{
> +   
frame()->page()->scrollingCoordinator()->frameViewHorizontalScrollbarLayerDidCh
ange(
> +	   this, layerForHorizontalScrollbar());
> +   
frame()->page()->scrollingCoordinator()->frameViewVerticalScrollbarLayerDidChan
ge(
> +	   this, layerForVerticalScrollbar());
> +}

I think all this is unnecessary too.

> Source/WebCore/platform/graphics/chromium/ScrollbarLayerChromium.cpp:285
> +    float widthScale = static_cast<float>(contentBounds().width()) /
bounds().width();
> +    float heightScale = static_cast<float>(contentBounds().height()) /
bounds().height();
> +
> +    scrollbarOrigin.scale(widthScale, heightScale);

Can I suggest a helper function to convert an IntRect from layer space into
content space?

> Source/WebCore/platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:157
> -    return WebKit::WebSize(m_owner->contentBounds().width(),
m_owner->contentBounds().height());
> +    return WebKit::WebSize(m_owner->bounds().width(),
m_owner->bounds().height());

Yeah, this is definitely correct.  It only worked before because bounds() ==
contentBounds() for scrollbar layers.