[webkit-reviews] review granted: [Bug 95094] [Chromium] Remove contentsScale from GraphicsLayerChromium and WebContentLayer : [Attachment 162378] Rename disregardsPageScale to boundsContainPageScale.

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted Jeff Timanus
<twiz at chromium.org>'s request for review:
Bug 95094: [Chromium] Remove contentsScale from GraphicsLayerChromium and
WebContentLayer
https://bugs.webkit.org/show_bug.cgi?id=95094

Attachment 162378: Rename disregardsPageScale to boundsContainPageScale.
https://bugs.webkit.org/attachment.cgi?id=162378&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162378&action=review


Dana convinced me that replica layers are always !drawsContent() and are just a
transform, essentially.  Looking at other code, we'd have other problems if
replica layers had contents.

R=me.  Thanks for wrestling with this mess.  :)

> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:-234
> -	   if (m_linkHighlight)
> -	       m_linkHighlight->invalidate();

I was a little dubious about this, but I think I've convinced myself that
because the m_linkHighlight layer is in the LayerChromium tree, that it'll get
setContentsScale() called on it, and that'll do the right invalidation.  And,
on top of that, the compositor properly handles any ordering of
setContentsScale / setNeedsDisplay.