[webkit-reviews] review granted: [Bug 95916] [WK2] Annotate multi-process FIXMEs with bug numbers : [Attachment 162379] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 5 18:29:43 PDT 2012


Eric Carlson <eric.carlson at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 95916: [WK2] Annotate multi-process FIXMEs with bug numbers
https://bugs.webkit.org/show_bug.cgi?id=95916

Attachment 162379: proposed patch
https://bugs.webkit.org/attachment.cgi?id=162379&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162379&action=review


> Source/WebKit2/ChangeLog:3
> +	   [WK2] Annotate multi-process FIXMEs with bug numbers

You might want to update the bug title because you did more than add bug
numbers to FIXMEs.

> Source/WebKit2/ChangeLog:21
> +	   (WebKit::WebPluginSiteDataManager::clearSiteData):
> +	   Removed FIXMEs - some ports haven't switched to plugin process yet,
but that
> +	   doesn't stop others from having a multi-process model.

And added ASSERT that plug-in process is enabled.


More information about the webkit-reviews mailing list